It seems that this PR will make the lib incompatible with previous version of the firmware.

Since the lib is currently not checking for the protocol version and locking connection, it needs to stay compatible with the old message. Either by checking the version and sending the appropriate message (maybe with a warning to update the Crazyflie), or by adding the new message in a new function.

Thanks for the review.
I see, I followed #134 where take_off was replaced by take_off_2...
Will make a new function instead 👌

So I made a new function.
Checking for the protocol version on the firmware side may have been more elegant, however, I have not figured out how to do that...

I've just approved the CI run as that hasn't been done yet, so please check if there are any errors there.

Also for the review we'll need to try this out ourselves just to make sure that everything still works, so we will try to do that before the next release.

Yes absolutely, that would be a nice feature. I'm not sure if we have a issue/ticket for the version checking yet. 🤔

The CI has failed on some autopep8 checks. @gemenerik will take a look at your PRs for test flight so if he can he'll fix it or you can fix it as well.

You can also run the test locally on your computer with the toolbelt: https://www.bitcraze.io/documentation/repository/toolbelt/master/ and tb verify. It should work for windows as well but there are some ifs/buts for the instructions.

Thanks, the failed checks should now be fixed.

I have tested this on the crazyflie with both the latest release as well as with the new firmware bitcraze/crazyflie-firmware#1410. All works as expected.

But indeed this should be tested by someone else before it gets pulled into master.